Skip to content
This repository has been archived by the owner on Jun 14, 2019. It is now read-only.

Please add ID/data-testid on every element requires user interaction #304

Open
19 of 26 tasks
mmelko opened this issue May 17, 2019 · 2 comments
Open
19 of 26 tasks

Please add ID/data-testid on every element requires user interaction #304

mmelko opened this issue May 17, 2019 · 2 comments
Assignees

Comments

@mmelko
Copy link
Contributor

mmelko commented May 17, 2019

This is a...


[x] Feature request
[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Documentation issue or request

Description

Currently test-suite depends heavily on pattern-fly-classes selectors. It'd be nice if every page fragment (for user interaction) could have id or data-testid attribute.

For example:

Navigation

  • Menu links done

Dashboard:

  • All buttons/links (Create integration, View all integrations, Create connections, view all connections)
  • integration list elements in Top 5 integrations - data-testid should contain integration name if possible.
  • Buttons/links within integration item
  • Connection card (link)
  • Connection card tittle
  • Recent updates - integration item - data-testid should contain integration name if possible.

Integrations page

  • all buttons/links
  • Items in integration list - data-testid should contain integration name if possible.
  • links within itegration item

integration details

  • all links/buttons

Integration editor

  • integration-flow steps
  • connection cards
  • Integration editor buttons (Create connection, cancel .. )
  • Connection action list item
  • Dropdown menus that aren't <select> tags (i.e Period time units)
  • Configuration action buttons (Choose action, Next)
  • Configuration action inputs (mostly done)

Connections page

  • Buttons
  • Connection cards (only tittles are)
  • heading tech-preview
  • Kebab menus
  • Connector cards
  • Connection configuration inputs
  • Connection configuration buttons

Settings

  • Oauth item heading

In summary: all buttons, inputs, links, headings bodies, menus :)

@gashcrumb
Copy link
Collaborator

Awesome, thanks for the checklist, that's probably most of the work right there 👍

@gashcrumb
Copy link
Collaborator

for the codemirror instance on the describe data page I wound up having to just put an ID on the containing div.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants