This repository has been archived by the owner on Jun 14, 2019. It is now read-only.
fix: expose the isInitialValid property and set it appropriately in the editor, add some IDs #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR Storybook available here |
|
create integration is broken, need to sort that |
|
PR Storybook available here |
|
PR Storybook available here |
|
K, should be all set. |
|
Now it doesn’t crash anymore - thanks! - but the next button is still disabled |
|
Found it! Loads of reasons for this button to be disabled initially apparently 😄 It just occurred to me that the form doesn't seem to be indicating required fields which would obviously help here, lemme figure that out too. |
…he editor, add some IDs; fixes syndesisio#270; fixes syndesisio#286
|
Added the required field indicator. |
|
PR Storybook available here |
|
Pull request approved by @riccardo-forina - applying approved label |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #270
fixes #286
and some stuff for #304