Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: fix error page render #1630

Merged
merged 1 commit into from
Apr 2, 2024
Merged

bug: fix error page render #1630

merged 1 commit into from
Apr 2, 2024

Conversation

w3cj
Copy link
Member

@w3cj w3cj commented Mar 29, 2024

Error page was not being used for top level errors like GET /nope

Screenshot 2024-03-29 at 1 57 02 PM

  • Moved +layout.server.ts and +error.svelte to root of routes
  • This catches 404s at the root and nested routes as well now GET /nope/never -> the start of a fix for Create a cool 404 page #1208

Copy link

vercel bot commented Mar 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
syntax-website ✅ Ready (Inspect) Visit Preview Mar 29, 2024 8:01pm

@w3cj w3cj marked this pull request as ready for review March 29, 2024 20:01
@wesbos
Copy link
Collaborator

wesbos commented Apr 2, 2024

ah awesome, I thought this would goof with the OG images but it's only on server layout.

@wesbos wesbos merged commit 4e3df20 into main Apr 2, 2024
2 of 3 checks passed
@stolinski stolinski deleted the fix-error-page branch April 5, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants