Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined custom property fixes #1911

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Undefined custom property fixes #1911

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8ce100c
851 (#1909)
github-actions[bot] Nov 22, 2024
9c5017e
CSS custom properties fixes + commenting suggestions
Nov 22, 2024
6fe9e78
undo unexpected version bump
Nov 22, 2024
66375f7
undo unexpected version bump
Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/lib/SelectMenu.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,8 @@
font-family: var(--body-font-family);
padding: 8px 14px;
cursor: pointer;
/* --body-font-size is never defined, maybe --font-size-base? */
/* also, this declaration 'overrides' line 105 */
font-size: var(--body-font-size);
color: var(--fg);
border-radius: 4px;
Expand Down
1 change: 1 addition & 0 deletions src/lib/search/SearchBox.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,6 +311,7 @@
bottom: 0;
text-align: right;
p {
/* --font-size-smallest is never defined, maybe --font-size-xs? */
font-size: var(--font-size-smallest);
color: white;
font-style: italic;
Expand Down
1 change: 1 addition & 0 deletions src/lib/search/SearchResultList.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,7 @@
}

a strong {
/* --sk-text-2 is undefined */
color: var(--sk-text-2);
}

Expand Down
2 changes: 2 additions & 0 deletions src/lib/search/SearchResults.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,9 @@
padding: 1rem;
font-size: 1.2rem;
text-transform: uppercase;
/* --sk-back-2 is never defined, maybe --black-2? */
background-color: var(--sk-back-2);
/* --sk-border-radius is never defined */
border-radius: 0 0 var(--sk-border-radius) var(--sk-border-radius);
pointer-events: all;
margin: 0;
Expand Down
2 changes: 1 addition & 1 deletion src/params/ThemeMaker.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@
height: 100vh;
overflow: hidden;
backdrop-filter: blur(10px);
color: var(--sheet-fg);
color: var(--fg-sheet);
padding: var(--default-padding);
overflow-y: scroll;
border-left: var(--border);
Expand Down
2 changes: 1 addition & 1 deletion src/routes/(site)/about/+page.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@
}
}
.desc {
color: var(--sheet-fg);
color: var(--fg-sheet);
background: color-mix(in oklab, var(--bg-1), transparent 4%);
width: 92%;
border-radius: var(--brad);
Expand Down
5 changes: 4 additions & 1 deletion src/styles/base.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,13 +173,14 @@

a,
.a {
/* --link-fg is never defined */
color: var(--link-fg, var(--fg));
text-decoration: none;
}

:is(p, li) a,
.a {
color: var(--color-sheet);
color: var(--fg-sheet);
text-decoration: underline;
text-decoration-color: var(--primary);
text-decoration-thickness: 1.5px;
Expand Down Expand Up @@ -225,6 +226,8 @@
padding: 4px 6px;
border-bottom: none;
text-decoration: none;

/* --color-2 is never defined */
color: var(--color-2);
border-radius: 4px;
position: relative;
Expand Down
2 changes: 2 additions & 0 deletions src/styles/buttons.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@
font-family: var(--body-font-family);
font-variation-settings: var(--fw-600);
padding: 6px 15px;

/* --body-font-size is never defined, maybe --font-size-base? */
font-size: var(--body-font-size);
border-radius: var(--brad);
background: var(--button-bg);
Expand Down
Loading