Fix status messages #397
Open
Fix status messages #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinclift
reviewed
Aug 1, 2019
| @@ -416,7 +415,7 @@ static const char stat_34[] = "Persistence error"; | |||
| static const char stat_35[] = "Bad status report setting"; | |||
| static const char stat_36[] = "Failed to get planner buffer"; | |||
|
|
|||
| static const char stat_37[] = "Backplan hit running buffer"; | |||
| static const char stat_37[] = "37"; | |||
There was a problem hiding this comment.
This seems to be removing a text string, replacing it with "37".
Doesn't seem correct?
There was a problem hiding this comment.
I removed the error message for code 37 since it appears to currently be marked as a placeholder.
TBH, I don't remember exactly why I believed it to be a placeholder, but I clearly thought about it at the time making it a separate commit and mentioning it in the PR message as well. If it's not correct however, then it shouldn't be included. Either way is fine with me.
|
@giseburt Thoughts on this PR? It's a pretty simple one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that a few status code error messages that seem to be out of date. The new error messages are my best guess at what a reasonable message would be, feel free to change them as desired. I removed the error message for code 37 since it appears to currently be marked as a placeholder.