Config fixes for gShield/gquintic #476
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rev c and earlier have compile errors I can't decipher.
While we're here fix a comment.
|
Yeah, that's an oversight. There were breaking changes between rev C and D on the quintic. We can maybe remove the Rev C code now and make sure anyone who has a C gets a newer board. |
|
@giseburt So, should this be merged? 😄 |
|
This one is simply a build fix; I can do a separate PR for adding the config option; I would also like to change it to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like
SPINDLE_SPEED_CHANGE_PER_MSisn't exposed as config but the other values in settings nearby are; I'm not sure if that's intentional or an oversight.For purposes of making axes move,
gquintic-dshould be pretty similar togquintic-c, right?