Fix images not being saved due to missing filesystem callbacks #491
Conversation
|
Thanks! This PR solves the issue as you mentioned: #473 Just want to confirm: The difference is only adding FSCallback to FS Writer API? No other changes to FS API? |
|
No other changes. Just directly passing the FSCallbacks through. Now the user pointer is actually the user pointer one would expect in all the callbacks. |
|
@tdapper could you give this branch a try? |
ptc-tgamper
force-pushed
the
bug/image_saving
branch
from
e9be35f
to
ff315a4
Compare
ptc-tgamper
force-pushed
the
bug/image_saving
branch
from
ff315a4
to
8720753
Compare
|
I can confirm that the small test case does not crash anymore. I am going to test it in our original context now. |
|
It also works in our original context. |
ptc-tgamper
force-pushed
the
bug/image_saving
branch
from
8720753
to
d522c9e
Compare
ptc-tgamper
force-pushed
the
bug/image_saving
branch
from
d522c9e
to
3861476
Compare
|
@ptc-tgamper Code is now OK(reviewed & CI test passes). I think its ready to merge. Do you have any further commits planned? |
|
Not at the moment. Please merge, as this gets memory consumption down by an order of magnitude for our use case. |
|
@ptc-tgamper Thanks! Merged! |
|
Created new release FYI: https://github.com/syoyo/tinygltf/releases/tag/v2.9.0 |
tiny_gltf.h - explicitly pass filesystem callbacks to image related functions
tester.cc - add respective test case, fix image uri test case