This repository has been archived by the owner on Oct 2, 2019. It is now read-only.
Rewrote the dial method, renamed the dictionaries, moved some text around... #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes the spec easier to write
Abstracted away stuff that relate to the telephony service interacting with network.
zolkis
added a commit
that referenced
this pull request
Jun 28, 2013
Rewrote the dial method, renamed the dictionaries, moved some text around...
|
Note that I will be out of network coverage until 5 July. |
|
no probs, see you when you are back! |
| <li>If <a>calls</a> array already contains a <a>TelephonyCall</a> | ||
| object with identical <a>remoteParty</a> attribute, then an | ||
| <code>InvalidModificationError</code> exception. | ||
| </li> |
There was a problem hiding this comment.
Why has this check been deleted?
There was a problem hiding this comment.
It was just re-ordered (not happens in step 5 of the algorithm), but not deleted. Making an object before all checks are done was incorrect. Might be best if you can check the rewrite here (hopefully it will make more sense): http://telephony.sysapps.org/#the-dial-method
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.