fix: use entrypoint/command from template when possibile #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francesco-racciatti
force-pushed
the
fix-entrypoint-command-override-taskdefinition
branch
from
e2c5166
to
e2bfc9c
Compare
francesco-racciatti
force-pushed
the
fix-entrypoint-command-override-taskdefinition
branch
from
e2bfc9c
to
c3fda09
Compare
Set the final entrypoint as defined in kilt-definition and use the overridden entrypoint/command from the template when possible. When the template overrides the entrypoint, the command won't be taken from the image. Signed-off-by: francesco-racciatti <[email protected]>
Signed-off-by: francesco-racciatti <[email protected]>
francesco-racciatti
force-pushed
the
fix-entrypoint-command-override-taskdefinition
branch
from
c3fda09
to
8fe6906
Compare
pgcrooks-sysdig
approved these changes
Feb 22, 2024
gnosek
approved these changes
Feb 23, 2024
francesco-racciatti
deleted the
fix-entrypoint-command-override-taskdefinition
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bugfix
What this PR does / why we need it:
Use the entrypoint/command overridden by the template if available.