Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(provisioning): add cloudformation templates and related GHA #42

Merged
merged 4 commits into from
Apr 22, 2024

Conversation

francesco-racciatti
Copy link
Collaborator

@francesco-racciatti francesco-racciatti commented Apr 19, 2024

Description

This pull request includes CloudFormation templates for deploying the serverless agent and adds the related GitHub Actions to facilitate the creation of RC tags and pre-releases, as well as the promotion of release candidates.

Actions are provided with a workflow_dispatch to be triggered via CI.

Furthermore, the agent-kilt golang executable is no longer distributed. It will be replaced by a docker image.

Best reviewed commit-by-commit.

@francesco-racciatti francesco-racciatti marked this pull request as ready for review April 19, 2024 16:08
@francesco-racciatti francesco-racciatti force-pushed the add-cloudformation-templates branch 2 times, most recently from 9ef750f to 12114df Compare April 19, 2024 16:16
Copy link
Collaborator

@pgcrooks-sysdig pgcrooks-sysdig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from one question. I wonder if we need to include the RC image tag in the CFT so QE can pull that to test.

.github/workflows/release.yml Outdated Show resolved Hide resolved
The release action will be used to make rc tags and prereleases that will be eventually promoted.
The rc distributes two attachments:
 - cloudformation.zip containing the cloudformation templates versioned by the prerelease action
 - checksum.txt containing the checksum of the resources attached to the prerelease

The agent-kilt golang executable is no longer distributed. It will be replaced by a docker image.

Signed-off-by: francesco-racciatti <[email protected]>
This action promotes the target RC tag and creates a release (marked as latest) based on it.

Signed-off-by: francesco-racciatti <[email protected]>
Copy link
Collaborator

@pgcrooks-sysdig pgcrooks-sysdig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@francesco-racciatti francesco-racciatti merged commit acfa2d6 into dev Apr 22, 2024
3 checks passed
@francesco-racciatti francesco-racciatti deleted the add-cloudformation-templates branch April 22, 2024 06:35
francesco-racciatti added a commit that referenced this pull request Jun 28, 2024
francesco-racciatti added a commit that referenced this pull request Jun 28, 2024
…GHA (#42)" (#93)

This PR reverts commit acfa2d6, 
thus restoring the previous release mechanism.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants