feat(node-analyzer): In-USE (EVE) enabled by default

sysdiglabs · Nov 29, 2023 · 7426802 · 7426802
1 parent 05748e0
commit 7426802
Show file tree

Hide file tree

Showing 6 changed files with 5 additions and 9 deletions.
diff --git a/charts/node-analyzer/Chart.yaml b/charts/node-analyzer/Chart.yaml
@@ -3,7 +3,7 @@ name: node-analyzer
 description: Sysdig Node Analyzer
 
 # currently matching Sysdig's appVersion 1.14.34
-version: 1.18.8
+version: 1.18.9
 appVersion: 12.9.0
 keywords:
   - monitoring

diff --git a/charts/node-analyzer/README.md b/charts/node-analyzer/README.md
@@ -228,7 +228,7 @@ The following table lists the configurable parameters of the Sysdig Node Analyze
 | `nodeAnalyzer.runtimeScanner.resources.limits.ephemeral-storage`     | Specifies the Runtime Scanner Storage limit per node.                                                                                                                                       | `4Gi`                                                                                                                                                                 |
 | `nodeAnalyzer.runtimeScanner.sslVerifyCertificate`                                  | Set to `false` to allow insecure connections to the Sysdig backend, such as an On-Prem deployment.                                                                                          |                                                                                                                                                                       |
 | `nodeAnalyzer.runtimeScanner.env`                                    | Specifies the extra environment variables that will be passed onto pods.                                                                                                                    | `{}`                                                                                                                                                                  |
-| `nodeAnalyzer.runtimeScanner.settings.eveEnabled`                    | Enables Sysdig Eve                                                                                                                                                                          | `false`                                                                                                                                                               |
+| `nodeAnalyzer.runtimeScanner.settings.eveEnabled`                    | Enables Sysdig Eve                                                                                                                                                                          | `true`                                                                                                                                                               |
 | `nodeAnalyzer.runtimeScanner.eveConnector.image.repository`          | Specifies the  image repository to pull the Eve Connector from.                                                                                                                             | `sysdig/eveclient-api`                                                                                                                                                |
 | `nodeAnalyzer.runtimeScanner.eveConnector.image.tag`                 | Specifies the image tag for the Eve Connector to be pulled.                                                                                                                                 | `1.1.0`                                                                                                                                                               |
 | `nodeAnalyzer.runtimeScanner.eveConnector.deploy`                    | Enables Sysdig Eve Connector for third-party integrations.                                                                                                                                  | `false`                                                                                                                                                               |

diff --git a/charts/node-analyzer/templates/daemonset-node-analyzer.yaml b/charts/node-analyzer/templates/daemonset-node-analyzer.yaml
@@ -719,8 +719,6 @@ spec:
                 name: {{ .Release.Name }}-runtime-scanner
                 key: eve_enabled
                 optional: true
-          {{- end }}
-          {{- if .Values.nodeAnalyzer.runtimeScanner.eveConnector.deploy }}
           - name: EVE_INTEGRATION_ENABLED
             valueFrom:
               configMapKeyRef:

diff --git a/charts/node-analyzer/templates/runtimeScanner/runtime-scanner-configmap.yaml b/charts/node-analyzer/templates/runtimeScanner/runtime-scanner-configmap.yaml
@@ -23,8 +23,6 @@ data:
   {{- end -}}
   {{- if .Values.nodeAnalyzer.runtimeScanner.settings.eveEnabled }}
   eve_enabled: "true"
-  {{- end -}}
-  {{- if hasKey .Values.nodeAnalyzer.runtimeScanner "eveConnector" }}
   eve_integration_enabled: "true"
   {{- end -}}
   {{- if hasKey .Values.nodeAnalyzer.runtimeScanner "settings" }}

diff --git a/charts/node-analyzer/tests/conditional_flag_test.yaml b/charts/node-analyzer/tests/conditional_flag_test.yaml
@@ -195,7 +195,7 @@ tests:
           count: 1
           any: true
 
-  - it: Check nodeAnalyzer runtimeScanner eveConnector deploy set to false
+  - it: Check nodeAnalyzer runtimeScanner EVE_INTEGRATION_ENABLED is true even if eveConnector deploy set to false
     set:
       nodeAnalyzer:
         runtimeScanner:
@@ -204,7 +204,7 @@ tests:
             deploy: false
       clusterName: test-k8s
     asserts:
-      - notContains:
+      - contains:
           path: spec.template.spec.containers[3].env
           content:
             name: EVE_INTEGRATION_ENABLED

diff --git a/charts/node-analyzer/values.yaml b/charts/node-analyzer/values.yaml
@@ -337,7 +337,7 @@ nodeAnalyzer:
     env: {}
 
     settings:
-      eveEnabled: false
+      eveEnabled: true
       # Threshold for which images will be skipped in the analysis.
       # Size is in bytes, default is not set (don't skip)
       # maxImageSizeAllowed: ""