-
Notifications
You must be signed in to change notification settings - Fork 127
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(agent,rapid-response): set metadata.namespace on all namespaced …
…items There were a handful of places in the charts related to `sysdig-deploy` where the `metadata.namespace` field was not being explicitly set. This is works out fine as Helm will set those fields itself during the `helm install` process, but does not do so during a call to `helm template`. What has been discovered is that for the workflow of generating manifest files via `helm template` and then applying them later with `kubectl apply -f ...`, certain CI utilities will patch the manifests not explicitly setting their namespace with a placeholder. When the subsequent `kubectl apply -f ...` command is run that supplies the desired namespace, the command fails because the namespace field is already set on some constructs and is different from what is being requested. This change ensures that all namespaced items have the values of `metadata.namespace` explicitly set to prevent the above issue.
- Loading branch information
1 parent
12a3330
commit 991b93c
Showing
9 changed files
with
13 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,7 +2,7 @@ apiVersion: v2 | |
name: sysdig-deploy | ||
description: A chart with various Sysdig components for Kubernetes | ||
type: application | ||
version: 1.14.0 | ||
version: 1.15.0 | ||
maintainers: | ||
- name: aroberts87 | ||
email: [email protected] | ||
|
@@ -20,7 +20,7 @@ dependencies: | |
- name: agent | ||
# repository: https://charts.sysdig.com | ||
repository: file://../agent | ||
version: ~1.11.0 | ||
version: ~1.12.0 | ||
alias: agent | ||
condition: agent.enabled | ||
- name: common | ||
|
@@ -48,6 +48,6 @@ dependencies: | |
- name: rapid-response | ||
# repository: https://charts.sysdig.com | ||
repository: file://../rapid-response | ||
version: ~0.6.2 | ||
version: ~0.7.0 | ||
alias: rapidResponse | ||
condition: rapidResponse.enabled |