Skip to content

Commit

Permalink
fix(cluster-scanner): corrected role to support OKD4
Browse files Browse the repository at this point in the history
  • Loading branch information
michele-mangili committed Jul 20, 2023
1 parent eeab8fe commit a0645f7
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 6 deletions.
2 changes: 1 addition & 1 deletion charts/cluster-scanner/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ description: Sysdig Cluster Scanner

type: application

version: 0.3.2
version: 0.3.3

appVersion: "0.1.0"
home: https://www.sysdig.com/
Expand Down
8 changes: 4 additions & 4 deletions charts/cluster-scanner/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ $ pre-commit run -a
$ helm repo add sysdig https://charts.sysdig.com
$ helm repo update
$ helm upgrade --install sysdig-cluster-scanner sysdig/cluster-scanner \
--create-namespace -n sysdig --version=0.3.2 \
--create-namespace -n sysdig --version=0.3.3 \
--set global.clusterConfig.name=CLUSTER_NAME \
--set global.sysdig.region=SYSDIG_REGION \
--set global.sysdig.accessKey=YOUR-KEY-HERE
Expand Down Expand Up @@ -55,7 +55,7 @@ To install the chart with the release name `cluster-scanner`, run:

```console
$ helm upgrade --install sysdig-cluster-scanner sysdig/cluster-scanner \
--create-namespace -n sysdig --version=0.3.2 \
--create-namespace -n sysdig --version=0.3.3 \
--set global.clusterConfig.name=CLUSTER_NAME \
--set global.sysdig.region=SYSDIG_REGION \
--set global.sysdig.accessKey=YOUR-KEY-HERE
Expand Down Expand Up @@ -146,7 +146,7 @@ Specify each parameter using the **`--set key=value[,key=value]`** argument to `

```console
$ helm upgrade --install sysdig-cluster-scanner sysdig/cluster-scanner \
--create-namespace -n sysdig --version=0.3.2 \
--create-namespace -n sysdig --version=0.3.3 \
--set global.sysdig.region="us1"
```

Expand All @@ -155,7 +155,7 @@ installing the chart. For example:

```console
$ helm upgrade --install sysdig-cluster-scanner sysdig/cluster-scanner \
--create-namespace -n sysdig --version=0.3.2 \
--create-namespace -n sysdig --version=0.3.3 \
--values values.yaml
```

Expand Down
2 changes: 2 additions & 0 deletions charts/cluster-scanner/templates/role.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ rules:
- apiGroups: ["*"]
resources:
- "endpoints"
# Following is required for OpenShift. See https://docs.openshift.com/container-platform/3.11/architecture/core_concepts/pods_and_services.html#endpoints
- "endpoints/restricted"
resourceNames:
- {{ include "cluster-scanner.fullname" . }}
verbs: ["*"]
1 change: 1 addition & 0 deletions charts/cluster-scanner/tests/role_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ tests:
apiGroups: ["*"]
resources:
- "endpoints"
- "endpoints/restricted"
resourceNames:
- test-release-cluster-scanner
verbs: ["*"]
Expand Down
2 changes: 1 addition & 1 deletion charts/sysdig-deploy/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ dependencies:
- name: cluster-scanner
# repository: https://charts.sysdig.com
repository: file://../cluster-scanner
version: ~0.3.2
version: ~0.3.3
alias: clusterScanner
condition: clusterScanner.enabled
- name: kspm-collector
Expand Down

0 comments on commit a0645f7

Please sign in to comment.