fix(shield): Fix cluster name & execute unit test in CI for the shiel…

…d chart (#1986)
sysdiglabs · Oct 17, 2024 · aa91cf1 · aa91cf1
1 parent 469dadd
commit aa91cf1
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 2 deletions.
diff --git a/.github/workflows/helm-unit-test.yaml b/.github/workflows/helm-unit-test.yaml
@@ -64,3 +64,6 @@ jobs:
 
       - name: Test sysdig-stackdriver-bridge
         run: helm unittest --strict ./charts/sysdig-stackdriver-bridge
+
+      - name: Test shield
+        run: helm unittest --strict -f 'tests/*/*_test.yaml' ./charts/shield
diff --git a/charts/shield/Chart.yaml b/charts/shield/Chart.yaml
@@ -13,5 +13,5 @@ maintainers:
   - name: mavimo
     email: [email protected]
 type: application
-version: 0.1.7
+version: 0.1.8
 appVersion: "1.0.0"
diff --git a/charts/shield/templates/host/_configmap_helpers.tpl b/charts/shield/templates/host/_configmap_helpers.tpl
@@ -66,7 +66,7 @@
 
 {{- define "host.configmap" }}
 {{- $config := dict
-  "cluster_name" .Values.cluster_config.name
+  "k8s_cluster_name" .Values.cluster_config.name
   "collector" (include "common.collector_endpoint" .)
   "collector_port" .Values.sysdig_endpoint.collector.port }}
 {{- $config = merge $config (dict "sysdig_api_endpoint" (include "common.secure_api_endpoint" .)) }}

diff --git a/charts/shield/tests/host/configmap-dragent-yaml_test.yaml b/charts/shield/tests/host/configmap-dragent-yaml_test.yaml
@@ -609,6 +609,16 @@ tests:
             long_float: 95.12345678912322
             long_int: 9545013498239122
 
+  - it: Set Cluster name
+    set:
+      cluster_config:
+        name: demo-cluster
+    asserts:
+      - matchRegex:
+          path: data['dragent.yaml']
+          pattern: |
+            k8s_cluster_name: demo-cluster
+
   - it: Set API endpoint
     set:
       sysdig_endpoint: