Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(admission-controller): Add KSPM Admission Controller to helm chart #1214

Merged
merged 46 commits into from
Aug 22, 2023
Merged

feat(admission-controller): Add KSPM Admission Controller to helm chart #1214

merged 46 commits into from
Aug 22, 2023

Conversation

airadier
Copy link
Collaborator

@airadier airadier commented Jul 3, 2023 •
edited
Loading

What this PR does / why we need it:

Checklist

  • Title of the PR starts with type and scope, (e.g. feat(agent,node-analyzer,sysdig-deploy):)
  • Chart Version bumped for the respective charts
  • Variables are documented in the README.md (or README.tpl in some charts)
  • Check GithubAction checks (like lint) to avoid merge-check stoppers
  • All test files are added in the tests folder of their respective chart and have a "_test" suffix

@github-actions github-actions bot added the no-tests Chart templates modified without test changes label Jul 3, 2023
github-actions[bot]
github-actions bot previously requested changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title does not comply with regex: ^(\w*)(?:\(([\w\$\.\,\-\*\s]*)\))?\:\s?(.*)$!
Check PR guidelines at https://github.com/sysdiglabs/charts/blob/master/README.md#pull-requests

@airadier airadier changed the title Ssprod 23092 integrate new admission controller to existing ac chart feat(admission-controller): Add KSPM Admission Controller to helm chart Jul 12, 2023
@github-actions github-actions bot dismissed their stale review July 12, 2023 14:01

All good!

@airadier airadier marked this pull request as ready for review August 8, 2023 16:12
@airadier airadier requested review from a team as code owners August 8, 2023 16:12
aroberts87
aroberts87 reviewed Aug 8, 2023
View reviewed changes
charts/admission-controller/Chart.yaml Outdated Show resolved Hide resolved
charts/sysdig-deploy/Chart.yaml Outdated Show resolved Hide resolved
charts/admission-controller/README.md Outdated Show resolved Hide resolved
charts/admission-controller/values.yaml Outdated Show resolved Hide resolved
airadier and others added 13 commits August 9, 2023 10:44
AlbertoBarba
AlbertoBarba approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@AlbertoBarba AlbertoBarba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@airadier airadier merged commit b9ab5ae into master Aug 22, 2023
5 checks passed
@airadier airadier deleted the SSPROD-23092_Integrate_new_Admission_Controller_to_existing_AC_chart branch August 22, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlbertoBarba AlbertoBarba AlbertoBarba approved these changes

@github-actions github-actions[bot] github-actions[bot] left review comments

@lilx1ao lilx1ao Awaiting requested review from lilx1ao

@aroberts87 aroberts87 Awaiting requested review from aroberts87

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@airadier @AlbertoBarba @aroberts87 @lilx1ao @lior-alafi-work