Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(admission-controller): Add labels to VAC webhook to adopt existing one #1238

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

airadier
Copy link
Collaborator

What this PR does / why we need it:

A recent change in the chart prevents the AC from installing if it was an upgrade from a previous version. The reason is that the old chart didn't treat the VAC registration as part of the lifecycle, and now we are doing.

To fix this, now we skip creating the resource as part of the lifecycle in case it already exists but doesn't contain the right annotations to be adopted. In the post-install hook we set the right annotations, so next upgrade or install, it will be adopted as part of the lifecycle and managed correct.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Title of the PR starts with type and scope, (e.g. feat(agent,node-analyzer,sysdig-deploy):)
  • Chart Version bumped for the respective charts
  • Variables are documented in the README.md (or README.tpl in some charts)
  • Check GithubAction checks (like lint) to avoid merge-check stoppers
  • All test files are added in the tests folder of their respective chart and have a "_test" suffix

Check Contribution guidelines in README.md for more insight.

@github-actions github-actions bot added the no-tests Chart templates modified without test changes label Jul 17, 2023
@airadier airadier marked this pull request as ready for review July 17, 2023 10:41
@airadier airadier requested a review from a team as a code owner July 17, 2023 10:41
@airadier airadier requested a review from dark-vex July 17, 2023 10:49
@airadier airadier merged commit 03f5b13 into master Jul 17, 2023
6 checks passed
@airadier airadier deleted the ac-adopt-existing-validatingwebhookconfiguration branch July 17, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-tests Chart templates modified without test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants