Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(node-analyzer): reformat configuration table in readme #1242

Merged
merged 2 commits into from
Jul 19, 2023

Conversation

aroberts87
Copy link
Collaborator

@aroberts87 aroberts87 commented Jul 18, 2023

What this PR does / why we need it:

A recent change to the configuration table in the README file had broken the formatting when viewed from charts.sysdig.com, despite rendering fine when viewed on GitHub directly. This change reformats the entire table to be compliant with markdown tables.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Title of the PR starts with type and scope, (e.g. feat(agent,node-analyzer,sysdig-deploy):)
  • Chart Version bumped for the respective charts
  • Check GithubAction checks (like lint) to avoid merge-check stoppers

Check Contribution guidelines in README.md for more insight.

A recent change to the configuration table in the README file had broken the
formatting when viewed from charts.sysdig.com, despite rendering fine when
viewed on GitHub directly. This change reformats the entire table to be
compliant with markdown tables.
@aroberts87 aroberts87 requested a review from a team July 18, 2023 21:14
@aroberts87 aroberts87 self-assigned this Jul 18, 2023
@aroberts87 aroberts87 enabled auto-merge (squash) July 19, 2023 18:24
@aroberts87 aroberts87 merged commit 1642add into master Jul 19, 2023
5 checks passed
@aroberts87 aroberts87 deleted the doc/fix_node_analyzer_readme_formatting branch July 19, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants