Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(agent): Remove a configuration parameter no longer required #1244

Merged
merged 1 commit into from
Jul 20, 2023
Merged

feature(agent): Remove a configuration parameter no longer required #1244

merged 1 commit into from
Jul 20, 2023

Conversation

mavimo
Copy link
Contributor

@mavimo mavimo commented Jul 19, 2023 •
edited
Loading

What this PR does / why we need it:

  • Remove a configuration parameter in the values.yaml that is no longer required.

Checklist

  • Title of the PR starts with type and scope, (e.g. feat(agent,node-analyzer,sysdig-deploy):)
  • Chart Version bumped for the respective charts
  • Variables are documented in the README.md (or README.tpl in some charts)
  • Check GithubAction checks (like lint) to avoid merge-check stoppers
  • All test files are added in the tests folder of their respective chart and have a "_test" suffix

@mavimo mavimo requested a review from a team as a code owner July 19, 2023 16:44
@mavimo mavimo self-assigned this Jul 19, 2023
@mavimo mavimo force-pushed the remove-configuration-parameter-not-more-required branch 2 times, most recently from 5cf4c4f to 3d379f3 Compare July 19, 2023 16:48
@mavimo mavimo force-pushed the remove-configuration-parameter-not-more-required branch from 3d379f3 to dbd45d9 Compare July 20, 2023 07:22
@mavimo mavimo enabled auto-merge (squash) July 20, 2023 07:22
@mavimo mavimo merged commit 85a2d48 into master Jul 20, 2023
5 checks passed
@mavimo mavimo deleted the remove-configuration-parameter-not-more-required branch July 20, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlbertoBarba AlbertoBarba AlbertoBarba approved these changes

@aroberts87 aroberts87 aroberts87 approved these changes

Assignees

@mavimo mavimo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mavimo @AlbertoBarba @aroberts87