feat(admission-controller): simplify CA and certificate options #1246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
no-tests
AlbertoBarba
approved these changes
Jul 20, 2023
…ided CA for trust
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
As discussed internally, there are no known requests to provide custom certificates or CA for the internal webhook, as it is automatically generated and the right CA bundle is provided on registration.
Moreover, the current implementation mixes CA certificate for trust with internal TLS certificate generation, which is not right. CA key should not be provided to the Helm chart
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
Check Contribution guidelines in README.md for more insight.