Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(admission-controller,agent,kspm-collector,node-analyzer,rapid-response,sysdig-deploy): update the unittest plugin #1248

Merged
merged 2 commits into from
Jul 24, 2023
Merged

feature(admission-controller,agent,kspm-collector,node-analyzer,rapid-response,sysdig-deploy): update the unittest plugin #1248

merged 2 commits into from
Jul 24, 2023

Conversation

mavimo
Copy link
Contributor

@mavimo mavimo commented Jul 20, 2023

What this PR does / why we need it:

  • Update the unittest helm's plugin
  • Fix tests

Checklist

  • Title of the PR starts with type and scope, (e.g. feat(agent,node-analyzer,sysdig-deploy):)
  • Chart Version bumped for the respective charts
  • Variables are documented in the README.md (or README.tpl in some charts)
  • Check GithubAction checks (like lint) to avoid merge-check stoppers
  • All test files are added in the tests folder of their respective chart and have a "_test" suffix

@mavimo mavimo self-assigned this Jul 20, 2023
@mavimo mavimo force-pushed the update-the-helm-unittest-plugin branch from c8294b1 to 5612a43 Compare July 24, 2023 09:28
@mavimo mavimo changed the title feature(admission-controller,agent): update the unittest plugin feature(admission-controller,agent,kspm-collector,node-analyzer,rapid-response,sysdig-deploy): update the unittest plugin Jul 24, 2023
@mavimo mavimo marked this pull request as ready for review July 24, 2023 09:29
@mavimo mavimo requested review from a team as code owners July 24, 2023 09:29
@mavimo
feature(admission-controller,agent): update the unittest plugin
89e5a46
@mavimo
feature(admission-controller,agent,kspm-collector,node-analyzer,rapid…
f119d84 
…-response,sysdig-deploy): update chart versions and remore unrequired tempalte specification in tests
@mavimo mavimo force-pushed the update-the-helm-unittest-plugin branch from 5612a43 to f119d84 Compare July 24, 2023 09:30
AlbertoBarba
AlbertoBarba approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@AlbertoBarba AlbertoBarba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏🏻

@mavimo mavimo merged commit ff6f9ec into master Jul 24, 2023
5 checks passed
@mavimo mavimo deleted the update-the-helm-unittest-plugin branch July 24, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francesco-furlan francesco-furlan francesco-furlan approved these changes

@AlbertoBarba AlbertoBarba AlbertoBarba approved these changes

Assignees

@mavimo mavimo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mavimo @francesco-furlan @AlbertoBarba