Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(agent,rapid-response): set metadata.namespace on all namespaced items #1259

Merged

Commits on Jul 24, 2023

  1. feat(agent,rapid-response): set metadata.namespace on all namespaced …

    …items
    
    There were a handful of places in the charts related to `sysdig-deploy` where
    the `metadata.namespace` field was not being explicitly set. This is works out
    fine as Helm will set those fields itself during the `helm install` process,
    but does not do so during a call to `helm template`. What has been discovered
    is that for the workflow of generating manifest files via `helm template` and
    then applying them later with `kubectl apply -f ...`, certain CI utilities will
    patch the manifests not explicitly setting their namespace with a placeholder.
    When the subsequent `kubectl apply -f ...` command is run that supplies the
    desired namespace, the command fails because the namespace field is already set
    on some constructs and is different from what is being requested. This change ensures that all namespaced items have the values of `metadata.namespace`
    explicitly set to prevent the above issue.
    aroberts87 committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    fa80c0a View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2023

  1. Configuration menu
    Copy the full SHA
    4a08f56 View commit details
    Browse the repository at this point in the history