Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node-analyzer): enable hostPID in node-analyzer #1271

Merged
merged 6 commits into from
Jul 31, 2023

Conversation

zohar-arad
Copy link
Contributor

@zohar-arad zohar-arad commented Jul 27, 2023

What this PR does / why we need it:

modify node-analyzer Helm chart and enable hostPID when .Values.global.kspm.deploy is set to true. This ensures that calls to systemctl during analysis will not fail.

See SSPROD-27133 for more details

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Title of the PR starts with type and scope, (e.g. feat(agent,node-analyzer,sysdig-deploy):)
  • Chart Version bumped for the respective charts
  • Variables are documented in the README.md (or README.tpl in some charts)
  • Check GithubAction checks (like lint) to avoid merge-check stoppers
  • All test files are added in the tests folder of their respective chart and have a "_test" suffix

Check Contribution guidelines in README.md for more insight.

… Values.global.kspm.deploy is set to true. This ensures that calls to systemctl during analysis will not fail
@github-actions github-actions bot added the no-tests Chart templates modified without test changes label Jul 27, 2023
@@ -3,7 +3,7 @@ name: node-analyzer
description: Sysdig Node Analyzer

# currently matching Sysdig's appVersion 1.14.34
version: 1.11.3
version: 1.11.4
Copy link
Contributor

@mavimo mavimo Jul 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems a behavioural change, I suggest to bump it as a minor, not as patch release.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mavimo thanks. done :)

@github-actions github-actions bot removed the no-tests Chart templates modified without test changes label Jul 27, 2023
@zohar-arad zohar-arad requested a review from a team as a code owner July 27, 2023 13:30
@zohar-arad zohar-arad merged commit 6dcb0a0 into master Jul 31, 2023
5 checks passed
@zohar-arad zohar-arad deleted the SSPROD-27133-ensure-hostpid-is-set-node-analyzer branch July 31, 2023 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants