Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(agent): fix Chart.yaml field #1293

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Conversation

aroberts87
Copy link
Collaborator

What this PR does / why we need it:

The agent release pipeline had not been updated to handle two version keys in the agent chart's Chart.yaml file and accidentally mangled the version field of the common chart dependency.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Title of the PR starts with type and scope, (e.g. feat(agent,node-analyzer,sysdig-deploy):)
  • Chart Version bumped for the respective charts
  • Variables are documented in the README.md (or README.tpl in some charts)
  • Check GithubAction checks (like lint) to avoid merge-check stoppers
  • All test files are added in the tests folder of their respective chart and have a "_test" suffix

Check Contribution guidelines in README.md for more insight.

The agent release pipeline had not been updated to handle two `version`
keys in the agent chart's `Chart.yaml` file and accidentally mangled
the version field of the `common` chart dependency.
@aroberts87 aroberts87 requested a review from a team as a code owner August 8, 2023 20:09
Copy link
Collaborator

@iurly iurly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @aroberts87 !

@aroberts87 aroberts87 merged commit 2de3cf9 into master Aug 8, 2023
5 of 6 checks passed
@aroberts87 aroberts87 deleted the fix/agent-chart-metadata branch August 8, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants