Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(admission-controller): Add support for worker skiptls #1317

Merged
merged 5 commits into from
Aug 29, 2023
Merged

Conversation

hayk99
Copy link
Contributor

@hayk99 hayk99 commented Aug 29, 2023

What this PR does / why we need it:

Add new param for the worker parametrization. In this case the ability to skip tls verify

SSPROD-29025

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Title of the PR starts with type and scope, (e.g. feat(agent,node-analyzer,sysdig-deploy):)
  • Chart Version bumped for the respective charts
  • Variables are documented in the README.md (or README.tpl in some charts)
  • Check GithubAction checks (like lint) to avoid merge-check stoppers
  • All test files are added in the tests folder of their respective chart and have a "_test" suffix

Check Contribution guidelines in README.md for more insight.

@hayk99 hayk99 requested a review from jprieto92 August 29, 2023 10:21
@hayk99 hayk99 self-assigned this Aug 29, 2023
@hayk99 hayk99 requested a review from a team as a code owner August 29, 2023 10:21
@github-actions github-actions bot added the no-tests Chart templates modified without test changes label Aug 29, 2023
@hayk99 hayk99 requested a review from jprieto92 August 29, 2023 13:14
@hayk99 hayk99 changed the title feat(admission-controller): Add support for worker skiptls [SSPROD-29025]feat(admission-controller): Add support for worker skiptls Aug 29, 2023
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title does not comply with regex: ^(\w*)(?:\(([\w\$\.\,\-\*\s]*)\))?\:\s?(.*)$!
Check PR guidelines at https://github.com/sysdiglabs/charts/blob/master/README.md#pull-requests

@hayk99 hayk99 changed the title [SSPROD-29025]feat(admission-controller): Add support for worker skiptls feat(admission-controller): Add support for worker skiptls Aug 29, 2023
@hayk99 hayk99 merged commit 640fa2e into master Aug 29, 2023
12 checks passed
@hayk99 hayk99 deleted the fix-skiptls branch August 29, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-tests Chart templates modified without test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants