Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common,agent,node-analyzer,kspm-collector): support multi-level map in agent.tags #1351

Merged
merged 3 commits into from
Sep 11, 2023

Conversation

zohar-arad
Copy link
Contributor

What this PR does / why we need it:

  • Support multi-level map in agent.tags helper (for example - role.server.primary:agent, role.server.secondary:scanner)
  • Update depending charts - agent,node-analyzer,kspm-collector
  • Remove duplicate call to agent.tags helper in agent config map
  • Use agent.tags helper in host-scanner config map, instead of rendering tags directly from map

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Title of the PR starts with type and scope, (e.g. feat(agent,node-analyzer,sysdig-deploy):)
  • Chart Version bumped for the respective charts
  • Variables are documented in the README.md (or README.tpl in some charts)
  • Check GithubAction checks (like lint) to avoid merge-check stoppers
  • All test files are added in the tests folder of their respective chart and have a "_test" suffix

Check Contribution guidelines in README.md for more insight.

@zohar-arad zohar-arad requested a review from a team as a code owner September 10, 2023 05:50
@zohar-arad zohar-arad merged commit 0806635 into master Sep 11, 2023
5 checks passed
@zohar-arad zohar-arad deleted the SSPROD-29789-fix-nested-agent-tags branch September 11, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants