Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(admission-controller): admission controller read does not read global.sysdig.accessKeySecret #1359

Merged

Conversation

AlbertoBarba
Copy link
Contributor

@AlbertoBarba AlbertoBarba commented Sep 14, 2023

What this PR does / why we need it:

https://sysdig.atlassian.net/browse/SMAGENT-5543

It seems that the admission-controller chart still uses an old version of the global.sysdig.accessKeySecret named existingAccessKeySecret.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Title of the PR starts with type and scope, (e.g. feat(agent,node-analyzer,sysdig-deploy):)
  • Chart Version bumped for the respective charts
  • Variables are documented in the README.md (or README.tpl in some charts)
  • Check GithubAction checks (like lint) to avoid merge-check stoppers
  • All test files are added in the tests folder of their respective chart and have a "_test" suffix

Check Contribution guidelines in README.md for more insight.

@AlbertoBarba AlbertoBarba self-assigned this Sep 14, 2023
@AlbertoBarba AlbertoBarba requested a review from a team as a code owner September 14, 2023 11:14
@AlbertoBarba AlbertoBarba requested a review from a team September 14, 2023 11:51
@AlbertoBarba AlbertoBarba merged commit 1a1fad6 into master Sep 14, 2023
6 checks passed
@AlbertoBarba AlbertoBarba deleted the fix/admission-controller-global-access-key-secret branch September 14, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants