Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(agent): add mount for host's /run vol for all deployment types #1373

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

aroberts87
Copy link
Collaborator

What this PR does / why we need it:

When installing on GKE Autopilot clusters with the agent slim mode selected the host's /run volume was not being mounted into the agent container. This was preventing the correct retrieval of container metrics.

Since the problematic scenario was the only case where the host's /run volume was not being mounted into the agent container, that volume has now been elevated to the "always requested" section.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Title of the PR starts with type and scope, (e.g. feat(agent,node-analyzer,sysdig-deploy):)
  • Chart Version bumped for the respective charts
  • Variables are documented in the README.md (or README.tpl in some charts)
  • Check GithubAction checks (like lint) to avoid merge-check stoppers
  • All test files are added in the tests folder of their respective chart and have a "_test" suffix

Check Contribution guidelines in README.md for more insight.

@aroberts87 aroberts87 requested a review from a team as a code owner September 27, 2023 02:30
@aroberts87 aroberts87 self-assigned this Sep 27, 2023
Copy link
Contributor

@mavimo mavimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We manually tested and now work as expected.

When installing on GKE Autopilot clusters with the agent slim mode selected
the host's `/run` volume was not being mounted into the agent container.
This was preventing the correct retrieval of container metrics.
@aroberts87 aroberts87 force-pushed the fix/smagent-5597-gke-autopilot-mounts branch from 8d0c788 to e43ce11 Compare September 27, 2023 16:23
@aroberts87 aroberts87 enabled auto-merge (squash) September 27, 2023 16:24
@aroberts87 aroberts87 merged commit 4f8ca5c into master Sep 27, 2023
5 checks passed
@aroberts87 aroberts87 deleted the fix/smagent-5597-gke-autopilot-mounts branch September 27, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants