Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(cloud-connector): DOC-3568 - setting arrays #1378

Closed
wants to merge 3 commits into from
Closed

chore(cloud-connector): DOC-3568 - setting arrays #1378

wants to merge 3 commits into from

Conversation

radhikapc
Copy link
Collaborator

@radhikapc radhikapc commented Sep 27, 2023 •
edited by mavimo
Loading

What this PR does / why we need it:

Checklist

  • Title of the PR starts with type and scope, (e.g. feat(agent,node-analyzer,sysdig-deploy):)
  • Chart Version bumped for the respective charts
  • Variables are documented in the README.md (or README.tpl in some charts)
  • Check GithubAction checks (like lint) to avoid merge-check stoppers
  • All test files are added in the tests folder of their respective chart and have a "_test" suffix

@radhikapc radhikapc requested a review from a team as a code owner September 27, 2023 21:48
github-actions[bot]
github-actions bot previously requested changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title does not comply with regex: ^(\w*)(?:\(([\w\$\.\,\-\*\s]*)\))?\:\s?(.*)$!
Check PR guidelines at https://github.com/sysdiglabs/charts/blob/master/README.md#pull-requests

@radhikapc radhikapc changed the title DOC-3568 - setting arrays chore (cloud-connector)- DOC-3568 - setting arrays Sep 27, 2023
@aroberts87 aroberts87 changed the title chore (cloud-connector)- DOC-3568 - setting arrays chore(cloud-connector): DOC-3568 - setting arrays Sep 28, 2023
aroberts87
aroberts87 requested changes Sep 28, 2023
View reviewed changes
Copy link
Collaborator

@aroberts87 aroberts87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @radhikapc ! The cloud-connector chart utilizes a template file that renders the README.md file. You'll need to move your edits to this template, otherwise they'll be immediately overwritten.

@radhikapc
Copy link
Collaborator Author

Hey @radhikapc ! The cloud-connector chart utilizes a template file that renders the README.md file. You'll need to move your edits to this template, otherwise they'll be immediately overwritten.

done. thank you for reminding me.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2023

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the stale The issue or pull request is inactive and will be closed soon label Dec 2, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2023

This PR has been closed due to inactivity.

@github-actions github-actions bot closed this Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aroberts87 aroberts87 aroberts87 requested changes

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
stale The issue or pull request is inactive and will be closed soon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radhikapc @aroberts87