Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(agent): do not render universal ebpf env vars in gke autopilot #1426

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

aroberts87
Copy link
Collaborator

The new environment variables needed for selecting universal eBPF were causing issues when installing on GKE Autopilot environments. This commit ensures that they are not used in those environments.

What this PR does / why we need it:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Title of the PR starts with type and scope, (e.g. feat(agent,node-analyzer,sysdig-deploy):)
  • Chart Version bumped for the respective charts
  • Variables are documented in the README.md (or README.tpl in some charts)
  • Check GithubAction checks (like lint) to avoid merge-check stoppers
  • All test files are added in the tests folder of their respective chart and have a "_test" suffix

Check Contribution guidelines in README.md for more insight.

The new environment variables needed for selecting universal eBPF
were causing issues when installing on GKE Autopilot environments.
This commit ensures that they are not used in those environments.
@aroberts87 aroberts87 self-assigned this Oct 23, 2023
@aroberts87 aroberts87 requested a review from a team as a code owner October 23, 2023 19:09
@aroberts87 aroberts87 merged commit e2a9985 into master Oct 23, 2023
6 checks passed
@aroberts87 aroberts87 deleted the smagent-5814-gke-autopilot-env-var-sanitization branch October 23, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants