Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node-analyzer,kspm-collector,sysdig-deploy): allow custom proxy for individual containers in node analyzer #1432

Conversation

mavimo
Copy link
Contributor

@mavimo mavimo commented Oct 27, 2023

What this PR does / why we need it:

Checklist

  • Title of the PR starts with type and scope, (e.g. feat(agent,node-analyzer,sysdig-deploy):)
  • Chart Version bumped for the respective charts
  • Variables are documented in the README.md (or README.tpl in some charts)
  • Check GithubAction checks (like lint) to avoid merge-check stoppers
  • All test files are added in the tests folder of their respective chart and have a "_test" suffix

@mavimo mavimo marked this pull request as draft October 27, 2023 12:58
@dark-vex dark-vex changed the title feat(node-analyser): allow custom proxy for individual containers in node analyser feat(node-analyser): allow custom proxy for individual containers in node analyzer Oct 27, 2023
@dark-vex dark-vex changed the title feat(node-analyser): allow custom proxy for individual containers in node analyzer feat(node-analyzer): allow custom proxy for individual containers in node analyzer Oct 27, 2023
@dark-vex dark-vex changed the title feat(node-analyzer): allow custom proxy for individual containers in node analyzer feat(node-analyzer,kspm-collector): allow custom proxy for individual containers in node analyzer Oct 27, 2023
@dark-vex
Copy link
Collaborator

@mavimo I think I've figured out why sysdig-deploy unit-test was failing.
It seems is because is not able to find the version of node-analyzer (since we bump it):

 ➜ helm dep update charts/sysdig-deploy
Hang tight while we grab the latest from your chart repositories...
...Successfully got an update from the "1password" chart repository
...Successfully got an update from the "longhorn" chart repository
...Successfully got an update from the "openebs" chart repository
...Successfully got an update from the "crowdsec" chart repository
...Successfully got an update from the "sysdig" chart repository
...Successfully got an update from the "bitnami" chart repository
Update Complete. ⎈Happy Helming!⎈
Error: can't get a valid version for repositories node-analyzer, kspm-collector. Try changing the version constraint in Chart.yaml

After a manual bump of sysdig-deploy the test is not failing neither locally or on GH pipeline

 ➜ helm unittest charts/sysdig-deploy

### Chart [ sysdig-deploy ] charts/sysdig-deploy

 PASS  Testing pre-generated values and best-known edge cases	charts/sysdig-deploy/tests/golden_template_test.yaml
 PASS  Test links in the notes section for regions	charts/sysdig-deploy/tests/notes_test.yaml
 PASS  Testing install commands in Readme	charts/sysdig-deploy/tests/readme_command_test.yaml
 PASS  Testing cluster scanner and runtime scanner should not be both enabled	charts/sysdig-deploy/tests/scannerconstraint_test.yaml

Charts:      1 passed, 1 total
Test Suites: 4 passed, 4 total
Tests:       65 passed, 65 total
Snapshot:    0 passed, 0 total
Time:        1.74095225s

@dark-vex dark-vex marked this pull request as ready for review October 29, 2023 11:54
@dark-vex dark-vex requested a review from a team as a code owner October 29, 2023 11:54
@dark-vex dark-vex self-assigned this Oct 29, 2023
@dark-vex dark-vex changed the title feat(node-analyzer,kspm-collector): allow custom proxy for individual containers in node analyzer feat(node-analyzer,kspm-collector,sysdig-deploy): allow custom proxy for individual containers in node analyzer Oct 29, 2023
Copy link
Contributor

@chen-shmilovich-sysdig chen-shmilovich-sysdig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mavimo mavimo force-pushed the ESC-3894-allow-custom-proxy-for-individual-containers-in-node-analyser branch from 3f710d8 to 26e6412 Compare October 31, 2023 09:19
@mavimo mavimo force-pushed the ESC-3894-allow-custom-proxy-for-individual-containers-in-node-analyser branch from cc0d9d6 to f65f225 Compare November 1, 2023 22:32
@mavimo mavimo merged commit f6f68ff into master Nov 2, 2023
5 checks passed
@mavimo mavimo deleted the ESC-3894-allow-custom-proxy-for-individual-containers-in-node-analyser branch November 2, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants