Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(agent,kspm-collector,node-analyzer,sysdig): whitespace errors #1436

Merged
merged 4 commits into from
Nov 2, 2023

Conversation

yurrriq
Copy link
Contributor

@yurrriq yurrriq commented Oct 31, 2023

What this PR does / why we need it:

Fix some whitespace errors in the four mentioned charts.

According to the YAML spec version 1.2 section 2.2 Structures, --- signals the start (not the end) of a document. Also, access-key was missing a leading space and had an extra trailing space in each of the charts.

Checklist

  • Title of the PR starts with type and scope, (e.g. feat(agent,node-analyzer,sysdig-deploy):)
  • Chart Version bumped for the respective charts
  • Check GithubAction checks (like lint) to avoid merge-check stoppers

@yurrriq yurrriq requested a review from a team as a code owner October 31, 2023 15:27
Copy link
Contributor

Hi @yurrriq. Thanks for your PR.

After inspecting your changes someone with write access to this repo needs
to approve and run the workflow with the following slash_command.

NOTE: the workflow triggered this way will only report the final status to this PR,
in order to check the logs please go to the Actions tab and look for approve-test-run-command.

  • /approve-test-run sha=<short commit sha to test>: Run helm chart linting and testing workflow

@github-actions github-actions bot added the no-tests Chart templates modified without test changes label Oct 31, 2023
@aroberts87
Copy link
Collaborator

/approve-test-run sha=ec68235

@aroberts87
Copy link
Collaborator

/approve-test-run sha=c2059bd

@aroberts87
Copy link
Collaborator

Hey @yurrriq! 👋🏻 Could you please bump the kspm-collector chart's patch version? After that I think we'll be good to merge this. Thanks again for the PR!
https://github.com/sysdiglabs/charts/actions/runs/6735301995/job/18308158940

@yurrriq
Copy link
Contributor Author

yurrriq commented Nov 2, 2023

Oops, thanks for catching that. I've bumped it now.

@aroberts87
Copy link
Collaborator

/approve-test-run sha=dbd9e2c

@aroberts87 aroberts87 merged commit f378d19 into sysdiglabs:master Nov 2, 2023
5 checks passed
@yurrriq yurrriq deleted the fix-whitespace-errors branch November 6, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-tests Chart templates modified without test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants