Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sysdig-deploy): Add prerequisite information on the chart #1468

Merged
merged 3 commits into from
Dec 18, 2023

Conversation

radhikapc
Copy link
Collaborator

@radhikapc radhikapc commented Nov 10, 2023

What this PR does / why we need it:

Add Prerequisite

DOC-3698

Checklist

  • Title of the PR starts with type and scope, (e.g. feat(agent,node-analyzer,sysdig-deploy):)
  • Chart Version bumped for the respective charts
  • Variables are documented in the README.md (or README.tpl in some charts)
  • Check GithubAction checks (like lint) to avoid merge-check stoppers
  • All test files are added in the tests folder of their respective chart and have a "_test" suffix

@radhikapc radhikapc requested a review from a team as a code owner November 10, 2023 18:34
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title does not comply with regex: ^(\w*)(?:\(([\w\$\.\,\-\*\s]*)\))?\:\s?(.*)$!
Check PR guidelines at https://github.com/sysdiglabs/charts/blob/master/README.md#pull-requests

@mavimo mavimo changed the title feat(sysdig-deploy) Add Prerequisite feat(sysdig-deploy): Add prerequisite information on the chart Nov 13, 2023
@mavimo mavimo force-pushed the DOC-3698-prereq branch 2 times, most recently from 777e0a9 to ea90af0 Compare November 14, 2023 10:42
@mavimo mavimo requested review from a team as code owners November 14, 2023 10:42
@aroberts87 aroberts87 enabled auto-merge (squash) December 18, 2023 17:15
@aroberts87 aroberts87 merged commit 49fe006 into master Dec 18, 2023
5 checks passed
@aroberts87 aroberts87 deleted the DOC-3698-prereq branch December 18, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants