Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: feat(node-analyzer,cluster-scanner): resolving bug with nodeAnalyzer and clusterScanner condition. #1479

Merged
merged 8 commits into from
Nov 16, 2023

Conversation

IgorEulalio
Copy link
Collaborator

What this PR does / why we need it:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • [ x ] Title of the PR starts with type and scope, (e.g. feat(agent,node-analyzer,sysdig-deploy):)
  • [ x ] Chart Version bumped for the respective charts
  • [ x ] Variables are documented in the README.md (or README.tpl in some charts)
  • [ x ] Check GithubAction checks (like lint) to avoid merge-check stoppers
  • [ x ] All test files are added in the tests folder of their respective chart and have a "_test" suffix

Check Contribution guidelines in README.md for more insight.

@IgorEulalio IgorEulalio requested a review from a team as a code owner November 16, 2023 16:24
@IgorEulalio IgorEulalio self-assigned this Nov 16, 2023
@IgorEulalio
Copy link
Collaborator Author

We found that the validation was having issues when executing it with helm version 3.9.3.

The mechanism to validate wether or not runtimeScanner or clusterScanner was improved to guarantee nested object validation before accessing it.

Two new unit tests were introduced to make sure deployments without nested objects (nodeAnalyzer and nodeAnalyzer.runtimeScanner) work properly.

Cc: @AlbertoBarba

@AlbertoBarba AlbertoBarba enabled auto-merge (squash) November 16, 2023 16:58
@AlbertoBarba AlbertoBarba merged commit 16386ec into master Nov 16, 2023
5 checks passed
@AlbertoBarba AlbertoBarba deleted the feature/SSPROD-33633 branch November 16, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants