Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cluster-scanner): Fix generate kubeconfig script to be able handle context name with special characters #1485

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

maratsal
Copy link
Contributor

@maratsal maratsal commented Nov 17, 2023

What this PR does / why we need it:

Fix generate_kubeconfig.sh script to be able handle context name with special characters, so that context name like arn:aws:eks:us-east-2:XXXXXXXXX:cluster/eks-i044e3wc would not cause problems on running script. All : and / will be replace by -

Checklist

  • Title of the PR starts with type and scope, (e.g. feat(agent,node-analyzer,sysdig-deploy):)
  • Chart Version bumped for the respective charts
  • Variables are documented in the README.md (or README.tpl in some charts)
  • Check GithubAction checks (like lint) to avoid merge-check stoppers
  • All test files are added in the tests folder of their respective chart and have a "_test" suffix

@aroberts87 aroberts87 enabled auto-merge (squash) December 19, 2023 14:30
@aroberts87 aroberts87 merged commit f4070c7 into master Dec 19, 2023
6 checks passed
@aroberts87 aroberts87 deleted the fix-generate-kubeconfig-script branch December 19, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants