Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(agent): update README.md #1497

Closed
wants to merge 0 commits into from
Closed

Conversation

yotakeu
Copy link

@yotakeu yotakeu commented Nov 29, 2023

Change image.tag default value from 12.16.0 to 12.18.0.

What this PR does / why we need it:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Title of the PR starts with type and scope, (e.g. feat(agent,node-analyzer,sysdig-deploy):)
  • Chart Version bumped for the respective charts
  • Variables are documented in the README.md (or README.tpl in some charts)
  • Check GithubAction checks (like lint) to avoid merge-check stoppers
  • All test files are added in the tests folder of their respective chart and have a "_test" suffix

Check Contribution guidelines in README.md for more insight.

@yotakeu yotakeu requested a review from a team as a code owner November 29, 2023 05:44
Copy link
Contributor

Hi @yotakeu. Thanks for your PR.

After inspecting your changes someone with write access to this repo needs
to approve and run the workflow with the following slash_command.

NOTE: the workflow triggered this way will only report the final status to this PR,
in order to check the logs please go to the Actions tab and look for approve-test-run-command.

  • /approve-test-run sha=<short commit sha to test>: Run helm chart linting and testing workflow

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title does not comply with regex: ^(\w*)(?:\(([\w\$\.\,\-\*\s]*)\))?\:\s?(.*)$!
Check PR guidelines at https://github.com/sysdiglabs/charts/blob/master/README.md#pull-requests

@mavimo
Copy link
Contributor

mavimo commented Nov 29, 2023

@yotakeu thanks for your contribution!

/approve-test-run sha=72e5c502513f9e15b1492897f5648762abe9fa17

@mavimo mavimo changed the title Update README.md chore(agent): update README.md Nov 29, 2023
@yotakeu yotakeu closed this Dec 15, 2023
@yotakeu yotakeu deleted the patch-1 branch December 15, 2023 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants