fix(agent): allows to specify non semver tags [SMAGENT-6093] #1504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
no-tests
AlbertoBarba
force-pushed
the
fix/SMAGENT-6093
branch
from
5a32bfb
to
805adb3
Compare
AlbertoBarba
force-pushed
the
fix/SMAGENT-6093
branch
from
805adb3
to
bc327cb
Compare
github-actions
bot
removed
the
no-tests
fuster92
reviewed
Nov 30, 2023
| @@ -219,7 +219,7 @@ spec: | |||
| value: /opt/draios/etc/ca-certs/{{- include "sysdig.custom_ca.keyName" (dict "global" .Values.global.ssl "component" .Values.ssl) -}} | |||
| {{- end }} | |||
| readinessProbe: | |||
| {{- if ge (semver "12.18.0" | (semver .Values.image.tag).Compare) 0 }} | |||
| {{- if eq (include "agent.enableHttpProbes" .) "true" }} | |||
| httpGet: | |||
| path: /healthz | |||
There was a problem hiding this comment.
A totally unrelated comment, is the z at the end on purpose?
There was a problem hiding this comment.
Yes, it's a sort of convention
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Due to the introduction of some features that are available since version
12.18.0we introduced a check on the version which fails if the provided tag is not a valid semantic version.Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
Check Contribution guidelines in README.md for more insight.