-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(agent): allows to specify non semver tags [SMAGENT-6093] #1504
Conversation
5a32bfb
to
805adb3
Compare
805adb3
to
bc327cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -219,7 +219,7 @@ spec: | |||
value: /opt/draios/etc/ca-certs/{{- include "sysdig.custom_ca.keyName" (dict "global" .Values.global.ssl "component" .Values.ssl) -}} | |||
{{- end }} | |||
readinessProbe: | |||
{{- if ge (semver "12.18.0" | (semver .Values.image.tag).Compare) 0 }} | |||
{{- if eq (include "agent.enableHttpProbes" .) "true" }} | |||
httpGet: | |||
path: /healthz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A totally unrelated comment, is the z
at the end on purpose?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's a sort of convention
What this PR does / why we need it:
Due to the introduction of some features that are available since version
12.18.0
we introduced a check on the version which fails if the provided tag is not a valid semantic version.Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
Check Contribution guidelines in README.md for more insight.