Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cluster-scanner): add verify registry as option in values #1516

Merged
merged 13 commits into from
Dec 5, 2023

Conversation

IgorEulalio
Copy link
Collaborator

What this PR does / why we need it:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • [ x ] Title of the PR starts with type and scope, (e.g. feat(agent,node-analyzer,sysdig-deploy):)
  • [ x ] Chart Version bumped for the respective charts
  • [ x ] Variables are documented in the README.md (or README.tpl in some charts)
  • [ x ] Check GithubAction checks (like lint) to avoid merge-check stoppers
  • [ x ] All test files are added in the tests folder of their respective chart and have a "_test" suffix

Check Contribution guidelines in README.md for more insight.

@IgorEulalio IgorEulalio requested review from a team as code owners December 5, 2023 12:53
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title does not comply with regex: ^(\w*)(?:\(([\w\$\.\,\-\*\s]*)\))?\:\s?(.*)$!
Check PR guidelines at https://github.com/sysdiglabs/charts/blob/master/README.md#pull-requests

@IgorEulalio IgorEulalio changed the title Feat/add verify registry as option in values feat(cluster-scanner): add verify registry as option in values Dec 5, 2023
@IgorEulalio IgorEulalio enabled auto-merge (squash) December 5, 2023 14:19
@github-actions github-actions bot added the no-tests Chart templates modified without test changes label Dec 5, 2023
@IgorEulalio IgorEulalio merged commit 4d5254f into master Dec 5, 2023
5 checks passed
@IgorEulalio IgorEulalio deleted the feat/add-verify-registry-as-option-in-values branch December 5, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-tests Chart templates modified without test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants