fix(agent): [SMAGENT-6037] fix the template failure for helm 3.9 #1524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mavimo
force-pushed
the
SMAGENT-6037-fix-templating-for-helm-3.9
branch
from
e8cb6a2
to
24f72d9
Compare
AlbertoBarba
requested changes
Jan 12, 2024
| {{- end }} | ||
| {{- if .Values.sysdig.settings }} | ||
| {{ toYaml .Values.sysdig.settings | nindent 4 }} |
There was a problem hiding this comment.
This might result in some duplication since https://github.com/sysdiglabs/charts/pull/1524/files#diff-3cf829d749cba0e0b831af9d7d58cd1b70ff2039e2af38f06523ef121fa47a72R47 we are already returning also .Values.sysdig.settings
mavimo
force-pushed
the
SMAGENT-6037-fix-templating-for-helm-3.9
branch
from
4c2aef5
to
8973d0f
Compare
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days |
github-actions
bot
added
the
stale
|
This PR has been closed due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Checklist
feat(agent,node-analyzer,sysdig-deploy))