Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(node-analyzer): Improve template to reflect eveEnabled settings in CM #1536

Merged
merged 3 commits into from
Dec 15, 2023

Conversation

airadier
Copy link
Collaborator

@airadier airadier commented Dec 15, 2023

What this PR does / why we need it:

As discussed in an internal escalation. Although we consider that manually updating a Configmap after rendering helm templates should be avoided, this change reflects the value of eveEnabled in the configmap variables instead of hardcoding to "true". This allows disabling / enabling eve integration just by updating the configmap.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Title of the PR starts with type and scope, (e.g. feat(agent,node-analyzer,sysdig-deploy):)
  • Chart Version bumped for the respective charts
  • Variables are documented in the README.md (or README.tpl in some charts)
  • Check GithubAction checks (like lint) to avoid merge-check stoppers
  • All test files are added in the tests folder of their respective chart and have a "_test" suffix

Check Contribution guidelines in README.md for more insight.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title does not comply with regex: ^(\w*)(?:\(([\w\$\.\,\-\*\s]*)\))?\:\s?(.*)$!
Check PR guidelines at https://github.com/sysdiglabs/charts/blob/master/README.md#pull-requests

@airadier airadier requested a review from mavimo December 15, 2023 11:15
@airadier airadier changed the title Improve template to reflect eveEnabled settings in CM chore(nodeAnalyzer): Improve template to reflect eveEnabled settings in CM Dec 15, 2023
@airadier airadier changed the title chore(nodeAnalyzer): Improve template to reflect eveEnabled settings in CM chore(node-analyzer): Improve template to reflect eveEnabled settings in CM Dec 15, 2023
@airadier airadier marked this pull request as ready for review December 15, 2023 11:21
@airadier airadier merged commit 9895cb0 into master Dec 15, 2023
5 checks passed
@airadier airadier deleted the improve-eve-flags branch December 15, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants