Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(agent): add kspm-analyzer specific settings to agent pod when enabled #1889

Merged
merged 3 commits into from
Aug 14, 2024

Conversation

aroberts87
Copy link
Collaborator

What this PR does / why we need it:

When the kspm-analzyer is enabled in the agent's configurations, certain additional attributes need to be set both in the agent configuration as well as the pod definition itself in order for the component to function correctly. This PR sets the requisite environment variable and port configurations on the agent pod in those scenarios.

Checklist

  • Title of the PR starts with type and scope, (e.g. feat(agent,node-analyzer,sysdig-deploy):)
  • Chart Version bumped for the respective charts
  • Check GithubAction checks (like lint) to avoid merge-check stoppers
  • All test files are added in the tests folder of their respective chart and have a "_test" suffix

for the kspm-analyzer to run as expected as a part of host shield, the
agent/host-shield container needs to expose the kspm-analyzer's agent
port, which is 12000 by default. additionally, the kspm-analyzer also
needs to have its agent_app_name set to match the selector used on the
agent pod.
@aroberts87 aroberts87 self-assigned this Aug 13, 2024
@aroberts87 aroberts87 requested a review from a team as a code owner August 13, 2024 20:52
@aroberts87 aroberts87 merged commit 4d0d730 into main Aug 14, 2024
4 checks passed
@aroberts87 aroberts87 deleted the aroberts/fix/kspm-analyzer-settings branch August 14, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants