Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node-analyzer): Reorder volume list #1922

Closed
wants to merge 2 commits into from

Conversation

gso-dc
Copy link
Contributor

@gso-dc gso-dc commented Sep 6, 2024

What this PR does / why we need it:

OpenShift stores the volume list in alphabetical order. To avoid unnecessary reconcile runs when using GitOps - align the order in helm chart with OpenShift expected order.

Checklist

  • Title of the PR starts with type and scope, (e.g. feat(agent,node-analyzer,sysdig-deploy):)
  • Check GithubAction checks (like lint) to avoid merge-check stoppers

Copy link
Contributor

github-actions bot commented Sep 6, 2024

Hi @gso-dc. Thanks for your PR.

After inspecting your changes someone with write access to this repo needs
to approve and run the workflow.

@mavimo
Copy link
Contributor

mavimo commented Sep 6, 2024

@gso-dc can you please bump also the related chart version in:

  • https://github.com/sysdiglabs/charts/blob/main/charts/node-analyzer/Chart.yaml#L5

if you don't mind the cluster-shield will be handled in a different PR as we use a different workflow for the chart upgrade..

@mavimo mavimo changed the title fix(cluster-shield,node-analyzer): Reorder volume list fix(node-analyzer): Reorder volume list Sep 11, 2024
@mavimo
Copy link
Contributor

mavimo commented Sep 12, 2024

@gso-dc replaced by #1934

BTW Cluster Shield was released a few days ago

@mavimo mavimo closed this Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants