Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shield): allow accesskey to be null in case access_key_existing_secret is set #1969

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

IgorEulalio
Copy link
Collaborator

What this PR does / why we need it:

Checklist

  • [ x ] Title of the PR starts with type and scope, (e.g. feat(agent,node-analyzer,sysdig-deploy):)
  • [ x ] Chart Version bumped for the respective charts
  • [ x ] Variables are documented in the README.md (or README.tpl in some charts)
  • [ x ] Check GithubAction checks (like lint) to avoid merge-check stoppers
  • [ x ] All test files are added in the tests folder of their respective chart and have a "_test" suffix

@IgorEulalio IgorEulalio requested a review from a team as a code owner October 7, 2024 22:55
@bashfulrobot
Copy link

This PR is for a situation where a user has set a value for access_key_existing_secret but not for access_key. I use sealed secrets, so I don't need the access_key.

@AlbertoBarba AlbertoBarba merged commit 3389a4e into main Oct 8, 2024
4 checks passed
@AlbertoBarba AlbertoBarba deleted the allow-accesskey-to-be-null branch October 8, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants