Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shield): allow custom env vars and volume mounts #1974

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

aroberts87
Copy link
Collaborator

What this PR does / why we need it:

Allow the users to specify custom environment variables and volumes/volume mounts into the Cluster Shield and Host Shield pods/containers.

Checklist

  • Title of the PR starts with type and scope, (e.g. feat(agent,node-analyzer,sysdig-deploy):)
  • Chart Version bumped for the respective charts
  • Variables are documented in the README.md (or README.tpl in some charts)
  • Check GithubAction checks (like lint) to avoid merge-check stoppers
  • All test files are added in the tests folder of their respective chart and have a "_test" suffix

@aroberts87 aroberts87 self-assigned this Oct 9, 2024
@aroberts87 aroberts87 requested a review from a team as a code owner October 9, 2024 20:57
@aroberts87 aroberts87 force-pushed the aroberts/feat/smagent-8161-custom-env-and-volumes branch from 19df91f to 7f0a878 Compare October 10, 2024 18:04
@aroberts87
Copy link
Collaborator Author

@AlbertoBarba - 7f0a878 was added purely to bypass the helm upgrade issue caused by the use of --reuse-values flag in the CI flows. Realistically this is not a situation we'll have to guard against at the moment due to the chart still being under heavy development. We can remove these in a follow up commit to reduce the cruft in the templates.

Allow the users to specify custom environment variables
and volumes/volume mounts into the Cluster Shield and
Host Shield pods/containers.
@aroberts87 aroberts87 force-pushed the aroberts/feat/smagent-8161-custom-env-and-volumes branch from 7f0a878 to bfddfc9 Compare October 14, 2024 13:35
@aroberts87 aroberts87 merged commit af7d38c into main Oct 14, 2024
4 checks passed
@aroberts87 aroberts87 deleted the aroberts/feat/smagent-8161-custom-env-and-volumes branch October 14, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants