ci: remove job execution on macos

We don't expect people running the GH Action on MacOS machines. Even the concept of creating an OCI image exclusively for MacOS doesn't make so much sense, the OCI images running on the Apple's OS are mostly Linux images.
sysdiglabs · Jul 29, 2024 · c6051a2 · c6051a2
1 parent c0ca3fa
commit c6051a2
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 62 deletions.
diff --git a/.github/workflows/ci-scan.yaml b/.github/workflows/ci-scan.yaml
@@ -77,41 +77,6 @@ jobs:
             echo "Scan failed as expected."
           fi
 
-  macos-scan-from-registry:
-    runs-on: macos-latest
-
-    steps:
-      # This step checks out a copy of your repository.
-      - name: Check out repository
-        uses: actions/checkout@v4
-
-      - name: Scan dummy-vuln-app from registry
-        id: scan
-        uses: ./
-        continue-on-error: true
-        with:
-          # Tag of the image to analyse
-          image-tag: sysdiglabs/dummy-vuln-app:latest
-          # API token for Sysdig Scanning auth
-          sysdig-secure-token: ${{ secrets.KUBELAB_SECURE_API_TOKEN }}
-          stop-on-failed-policy-eval: true
-          stop-on-processing-error: true
-
-      - name: Upload SARIF file
-        if: success() || failure() # Upload results regardless previous step fails
-        uses: github/codeql-action/upload-sarif@v3
-        with:
-          sarif_file: ${{ github.workspace }}/sarif.json
-
-      - name: Check that the scan has failed
-        run: |
-          if [ "${{ steps.scan.outcome }}" == "success" ]; then
-            echo "Scan succeeded but the step should fail."
-            exit 1
-          else
-            echo "Scan failed as expected."
-          fi
-
   standalone-scan-from-registry:
     runs-on: ubuntu-latest
 

diff --git a/.github/workflows/scan.yaml b/.github/workflows/scan.yaml
@@ -57,32 +57,6 @@ jobs:
         with:
           sarif_file: ${{ github.workspace }}/sarif.json
 
-  macos-scan-from-registry:
-    runs-on: macos-latest
-
-    steps:
-      # This step checks out a copy of your repository.
-      - name: Check out repository
-        uses: actions/checkout@v4
-
-      - name: Scan dummy-vuln-app from registry
-        id: scan
-        uses: ./
-        with:
-          # Tag of the image to analyse
-          image-tag: sysdiglabs/dummy-vuln-app:latest
-          # API token for Sysdig Scanning auth
-          sysdig-secure-token: ${{ secrets.KUBELAB_SECURE_API_TOKEN }}
-          stop-on-failed-policy-eval: true
-          stop-on-processing-error: true
-
-      - name: Upload SARIF file
-        if: success() || failure() # Upload results regardless previous step fails
-        uses: github/codeql-action/upload-sarif@v3
-        with:
-          sarif_file: ${{ github.workspace }}/sarif.json
-
-
   standalone-scan-from-registry:
     runs-on: ubuntu-latest
 
@@ -119,4 +93,4 @@ jobs:
         if: success() || failure() # Upload results regardless previous step fails
         uses: github/codeql-action/upload-sarif@v3
         with:
-          sarif_file: ${{ github.workspace }}/sarif.json
+          sarif_file: ${{ github.workspace }}/sarif.json