feat(cloud-bench) Ensure CloudAccount is created after Lighthouse #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravinadhruve10
approved these changes
Aug 30, 2023
|
Yeah, test kitchen is not properly configured and probably should be disabled until it is set up correctly. pre-commit is failing due to provider version bumps, which I don't want to change in this PR. |
hayk99
approved these changes
Aug 31, 2023
miketnt
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating the Cloud Account object in Sysdig causes downstream features to begin processing. If lighthouse is not in place, these scans will fail. This PR ensures that lighthouse is in place before any scans are triggered by making the cloud account depend on the lighthouse resources.