Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Replace deprecated log field with enabled_log #95

Merged
merged 3 commits into from
Sep 7, 2023

Conversation

nkraemer-sysdig
Copy link
Contributor

#93 did not completely resolve the deprecated field issue. Please see the first commit for the primary changes in this PR.

Later commits bump the version constraints for the azurerm and azuread providers, as well as split the version constraints to separate versions.tf files in the test fixtures.

@nkraemer-sysdig
Copy link
Contributor Author

Manually tested single subscription install of cloudconnector + cloudbench

@mdkulkarni15
Copy link

A few errors in the Tests, are they intermittent?

@nkraemer-sysdig
Copy link
Contributor Author

The test-kitchen tests do not have a valid environment to point to. We need to provision a long-term test account where these tests can point.

@nkraemer-sysdig nkraemer-sysdig merged commit f047e3f into master Sep 7, 2023
17 of 18 checks passed
@nkraemer-sysdig nkraemer-sysdig deleted the fix/azure-logs branch September 7, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants