Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(serverless-agent): add parameter to use bare pdig to instrument certain containers #380

Merged

Conversation

francesco-racciatti
Copy link
Contributor

@francesco-racciatti francesco-racciatti commented Jul 10, 2023

Description

This PR adds the list parameter bare_pdig_on_containers to the fargate_workload_agent data source.
bare_pdig_on_containers gets the list of the containers to be instrumented through bare pdig (thus disabling optimizations).

Copy link
Contributor

@pgcrooks-sysdig pgcrooks-sysdig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pgcrooks-sysdig pgcrooks-sysdig force-pushed the feat(serverless-agent)-add-option-to-use-bare-pdig branch from e968ae5 to 367879d Compare July 14, 2023 16:14
Base automatically changed from SSPROD-26266_kilt-ignore to master July 20, 2023 15:56
@francesco-racciatti francesco-racciatti force-pushed the feat(serverless-agent)-add-option-to-use-bare-pdig branch from 367879d to 83d91c3 Compare August 3, 2023 12:55
@francesco-racciatti francesco-racciatti force-pushed the feat(serverless-agent)-add-option-to-use-bare-pdig branch from 5224171 to fd015f0 Compare August 3, 2023 15:29
@francesco-racciatti francesco-racciatti force-pushed the feat(serverless-agent)-add-option-to-use-bare-pdig branch from fd015f0 to 1ba19f8 Compare September 19, 2023 14:55
@francesco-racciatti francesco-racciatti merged commit eebe2b6 into master Oct 24, 2023
23 checks passed
@francesco-racciatti francesco-racciatti deleted the feat(serverless-agent)-add-option-to-use-bare-pdig branch October 24, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants