feat(teams) Add custom role data source #382
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DagDigg
reviewed
Jul 11, 2023
| } | ||
|
|
||
| func dataSourceSysdigCustomRoleRead(ctx context.Context, d *schema.ResourceData, m interface{}) diag.Diagnostics { | ||
| client, err := m.(SysdigClients).sysdigCommonClientV2() |
There was a problem hiding this comment.
I would do a check regarding the type cast, to avoid any panic in the application
cli, ok := m.(SysdigClients)
DagDigg
reviewed
Jul 11, 2023
| return diag.FromErr(err) | ||
| } | ||
|
|
||
| name := d.Get("name").(string) |
DagDigg
reviewed
Jul 11, 2023
| } | ||
|
|
||
| d.SetId(strconv.Itoa(customRole.ID)) | ||
| _ = d.Set("name", customRole.Name) |
There was a problem hiding this comment.
feel free to omit the _ = if you don't need them :)
Shadow649
force-pushed
the
SP-950_custom_role_data_source
branch
from
ef1aea0
to
8b3c7f1
Compare
|
closing everything will be done in #383 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is first PR in order to add tthe ability to assign custom roles to users in teams
Changes made in the PR:
Tests are missing and will be added in a later stage, when we introduce the custom role resource.