Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (team service account) Manage Team Based Service Account as Terraform resource #386

Merged
merged 9 commits into from
Jul 24, 2023

Conversation

Shadow649
Copy link
Collaborator

This PR adds support for managing team service account via sysdig_team_service_account resource for both monitor and secure teams.

@Shadow649 Shadow649 self-assigned this Jul 20, 2023
@Shadow649 Shadow649 marked this pull request as ready for review July 21, 2023 13:08
@@ -0,0 +1,97 @@
//go:build tf_acc_sysdig_monitor || tf_acc_sysdig_secure
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the feature available for IBM?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now we don't support team service account in IBM envs.


func teamServiceAccountFromResourceData(d *schema.ResourceData) *v2.TeamServiceAccount {
return &v2.TeamServiceAccount{
Name: d.Get("name").(string),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change here as well

}

func teamServiceAccountToResourceData(teamServiceAccount *v2.TeamServiceAccount, d *schema.ResourceData) error {
err := d.Set("name", teamServiceAccount.Name)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also here

Copy link
Collaborator

@filiptubic filiptubic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Shadow649 Shadow649 force-pushed the SP-947_team_service_account branch from 78a916a to 8ec5225 Compare July 24, 2023 12:52
@Shadow649 Shadow649 merged commit 41345d3 into master Jul 24, 2023
23 checks passed
@Shadow649 Shadow649 deleted the SP-947_team_service_account branch July 24, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants