Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(secure-rule, secure-policy) use status code to determine if resource needs to be recreated #409

Merged
merged 3 commits into from
Sep 8, 2023
Merged

feat(secure-rule, secure-policy) use status code to determine if resource needs to be recreated #409

merged 3 commits into from
Sep 8, 2023

Conversation

kmvachhani
Copy link
Contributor

@kmvachhani kmvachhani commented Sep 8, 2023 •
edited
Loading

We should differentiate between 404 errors and all other errors when trying to get a rule from the backend. If the response is non 404, we should not try to re-create the resource, as it might already exist.

@kmvachhani kmvachhani changed the title use status code to determine if resource needs to be recreated feat(secure-rule) use status code to determine if resource needs to be recreated Sep 8, 2023
ombellare
ombellare reviewed Sep 8, 2023
View reviewed changes
Copy link
Contributor

@ombellare ombellare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would the same be required for when a GetPolicyByID returns a 404?

@kmvachhani
Copy link
Contributor Author

Would the same be required for when a GetPolicyByID returns a 404?

yup I talked to @ben-m-lucas about this, going to add this in for policies too

@kmvachhani kmvachhani marked this pull request as ready for review September 8, 2023 17:59
ombellare
ombellare approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@ombellare ombellare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kmvachhani kmvachhani changed the title feat(secure-rule) use status code to determine if resource needs to be recreated feat(secure-rule, secure-policy) use status code to determine if resource needs to be recreated Sep 8, 2023
@kmvachhani kmvachhani merged commit 000b507 into master Sep 8, 2023
23 checks passed
@kmvachhani kmvachhani deleted the feat/detection-policies-handle-non-404-errors branch September 8, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ombellare ombellare ombellare approved these changes

@jacklongsd jacklongsd Awaiting requested review from jacklongsd

@ben-m-lucas ben-m-lucas Awaiting requested review from ben-m-lucas

@miguelgordo miguelgordo Awaiting requested review from miguelgordo miguelgordo is a code owner

@ivanlysiuk-sysdig ivanlysiuk-sysdig Awaiting requested review from ivanlysiuk-sysdig ivanlysiuk-sysdig is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kmvachhani @ombellare